Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aggregate inputs #1317

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Remove aggregate inputs #1317

wants to merge 3 commits into from

Conversation

mabijkerk
Copy link
Member

@mabijkerk mabijkerk commented Jan 27, 2023

This migration concerns the following keys:

These keys stem from a time when the fertilizer sector was not explicitly modelled for every dataset. This was the case in datasets where has_aggregated_chemical_industry = true.

When these aggregate inputs are set in combination with the individual inputs of the fertilizer and other chemical sector however, the demand from the fertilizer sector goes to 0. This is not intentional and can present problems for scenarios where these inputs have been set.

Since all datasets currently have an explicit fertilizer sector and the aggregate inputs are not accessible in the frontend, we want to remove the aggregate inputs from all recent scenarios (>2021). We can then remove the inputs from ETSource altogether.

@noracato when I check the presence of each slider in migratable scenarios I get 682, 1564 and 1564 cases. However, when I run the migration I get 7663 migrated scenarios. Could you look into this to see where this difference comes from?

Merging is on hold until cleared by ENTSO.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Apr 3, 2023
@mabijkerk mabijkerk added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants