Don't update remote client CIDs gratuitously #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Feb 9, 2022
There was a problem hiding this comment.
I'm not very familiar with this logic, so this is a bit of a superficial review.
@Matthias247 would you mind reviewing this?
Handling retire_prior_to might have already moved us off the initial CID.
Ralith
force-pushed
the
cid-fix
branch
2 times, most recently
from
0facb62
to
cc494dd
Compare
djc
reviewed
Feb 10, 2022
|
That looks like an impressive refactoring. My confidence in my own judgement is still low, but it looks good to me. (And especially with the added documentation and test coverage it feels like a clear improvement.) |
djc
previously approved these changes
Feb 10, 2022
This predicate was based on whether an entry in the circular CID buffer was unset. However, that entry might have already been overwritten with newer data. Meanwhile, because we guarantee that the active CID is always at the start of the sliding window of CID sequence numbers, we can easily infer whether the previously-active CID was retired and replaced by retire_prior_to by whether the retired set it returns is empty.
We were disabling it every time we updated the remote CID, and we like to update the remote CID ASAP for servers to enable client-side stateless resets. Instead, we should disable it only when switching remote CIDs due to a migration.
|
Tidied things up a bit more, in particular to get rid of the dubious |
Duplicates of the in-use remote CID do not need to be handled differently from duplicates of buffered, unused CIDs.
djc
approved these changes
Feb 11, 2022
|
We should probably timeout on additional reviews and just get this merged. It seems unlikely to be worse given the added tests! |
Matthias247
reviewed
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling retire_prior_to might have already moved us off the initial CID.