Skip to content

Commit

Permalink
Fix the spin bit becoming immediately disabled for servers
Browse files Browse the repository at this point in the history
We were disabling it every time we updated the remote CID, and we like
to update the remote CID ASAP for servers to enable client-side
stateless resets. Instead, we should disable it only when switching
remote CIDs due to a migration.
  • Loading branch information
Ralith committed Feb 9, 2022
1 parent fe4f4c3 commit 55aae16
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions quinn-proto/src/connection/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2586,6 +2586,7 @@ impl Connection {
self.migrate(now, remote);
// Break linkability, if possible
let _ = self.update_rem_cid();
self.spin = false;
}

Ok(())
Expand Down Expand Up @@ -2643,9 +2644,6 @@ impl Connection {
reset_token,
));
self.peer_params.stateless_reset_token = Some(reset_token);

// Reduce linkability
self.spin = false;
}

/// Issue an initial set of connection IDs to the peer
Expand Down

0 comments on commit 55aae16

Please sign in to comment.