fix: when compositionend after InlineEmbed element, selection do not update #4067
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpj-wpj-wpj
commented
Mar 20, 2024
| }); | ||
|
|
||
| if (mutation) { | ||
| const range = this.restore(mutation.target as Text); |
There was a problem hiding this comment.
here is what this.restore does:
- get text from
mutation.target.data, - calculate range by text
- reset
mutation.target.datato empty
so only the first execution of this.restore is effective
the next execution will get empty text from mutation.target.data, and return wrong range, which is the cause of the issue #4046
luin
force-pushed
the
main
branch
2 times, most recently
from
fb1018a
to
de1afe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix：#4046
after fix:
2024-03-20.17.49.55.mov