Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve bubble tooltip positioning in multiline ranges (#706) #3228

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mumpo
Copy link

@mumpo mumpo commented Nov 16, 2020

What does this PR do?

This PR extends the tooltip position correction for multiple line selections added here eb4a1cd , adding the same calculation for any optimize event related recalculations.

How to reproduce?

  1. Configure the editor with bubble theme
  2. Type a 3 line text
  3. Select everything
  4. The toolbar tooltip appears in the correct position (thanks to previous fix)
  5. Click the bold format or any format
  6. The position of the tooltip is recalculated incorrectly

Related issue

Improves the fix for this issue: #706

Copy link

@eliasdevpf eliasdevpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants