Include stop word lists from the Snowball project #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Nov 8, 2022
fulmicoton
reviewed
Nov 8, 2022
fulmicoton
reviewed
Nov 8, 2022
|
The list in Lucene is much shorter I believe @adamreichold . |
fulmicoton
reviewed
Nov 9, 2022
fulmicoton
reviewed
Nov 9, 2022
fulmicoton
reviewed
Nov 9, 2022
fulmicoton
reviewed
Nov 9, 2022
fulmicoton
reviewed
Nov 9, 2022
|
@adamreichold I still have a bunch of comments. Sorry for the multiple iterations. I hope it does not seem too arbitrary. Your energy and attention to detail is actually well appreciated! ❤️ |
Better to take care and try to do it right than to slowly turn a FOSS project into a dumping ground for half-assed code drops. I don't mind iterating on this at all. |
fulmicoton
approved these changes
Nov 9, 2022
|
Thank you! |
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion in #1651 (comment), this follows Apache Lucene by incorporating the stop word lists from the BSD-licensed Snowball project.