No score calls if score is not requested #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
no_score_calls
branch
from
8815c69
to
af83975
Compare
fulmicoton
reviewed
Oct 26, 2022
src/query/weight.rs
Outdated
| @@ -7,12 +7,21 @@ use crate::{DocId, Score, TERMINATED}; | |||
| /// `DocSet` and push the scored documents to the collector. | |||
| pub(crate) fn for_each_scorer<TScorer: Scorer + ?Sized>( | |||
| scorer: &mut TScorer, | |||
| requires_scoring: bool, | |||
There was a problem hiding this comment.
Can we not add this parameter to this function and instead create a separate function:
pub(crate) fn for_each_docset<TDocSet: DocSet + ?Sized>(
docset: &mut TDocset,
callback: &mut dyn FnMut(DocId)
) -> { ... }There was a problem hiding this comment.
I updated the PR, but it still adds a fake score when collect()ing
Codecov Report
@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
+ Coverage 93.97% 94.04% +0.06%
==========================================
Files 253 255 +2
Lines 47716 48616 +900
==========================================
+ Hits 44843 45720 +877
- Misses 2873 2896 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shikhar
reviewed
Oct 26, 2022
shikhar
reviewed
Oct 26, 2022
| reader: &SegmentReader, | ||
| callback: &mut dyn FnMut(DocId), | ||
| ) -> crate::Result<()> { | ||
| let scorer = self.complex_scorer(reader, 1.0, &self.score_combiner_fn)?; |
There was a problem hiding this comment.
Does &DoNothingCombiner make sense here?
There was a problem hiding this comment.
I think so, but it's not called anyway
fulmicoton
reviewed
Nov 1, 2022
Co-authored-by: Paul Masurel <paul@quickwit.io>
PSeitz
force-pushed
the
no_score_calls
branch
from
45f9e67
to
2af6b01
Compare
fulmicoton
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those score calls can add add up in cost