Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip field #1553

Merged
merged 27 commits into from Oct 11, 2022
Merged

ip field #1553

merged 27 commits into from Oct 11, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Sep 26, 2022

  • add u128 multivalue reader and writer
  • add ip to schema
  • add ip writers, handle merge

fulmicoton
fulmicoton reviewed Sep 26, 2022
View reviewed changes
src/fastfield/writer.rs Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Sep 26, 2022
View reviewed changes
src/fastfield/writer.rs Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Sep 26, 2022
View reviewed changes
src/fastfield/writer.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022 •
edited

Codecov Report

Merging #1553 (b2ca83a) into main (5f565e7) will increase coverage by 0.06%.
The diff coverage is 90.18%.

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   93.78%   93.85%   +0.06%     
==========================================
  Files         252      253       +1     
  Lines       46380    47074     +694     
==========================================
+ Hits        43499    44181     +682     
- Misses       2881     2893      +12
Impacted Files Coverage Δ
fastfield_codecs/src/main.rs 0.53% <0.00%> (-0.01%) ⬇️
src/fastfield/mod.rs 99.71% <ø> (ø)
src/fastfield/multivalued/mod.rs 98.45% <ø> (-0.78%) ⬇️
src/indexer/segment_writer.rs 96.23% <0.00%> (-0.18%) ⬇️
src/postings/per_field_postings_writer.rs 94.11% <ø> (ø)
src/postings/postings_writer.rs 97.66% <0.00%> (-0.58%) ⬇️
src/query/query_parser/query_parser.rs 94.67% <0.00%> (-0.34%) ⬇️
src/schema/mod.rs 100.00% <ø> (ø)
src/schema/term.rs 85.32% <0.00%> (-0.34%) ⬇️
src/schema/field_type.rs 74.14% <9.52%> (-4.11%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz force-pushed the ip_field branch 4 times, most recently from 992b259 to 6834424 Compare September 27, 2022 02:24
fulmicoton
fulmicoton reviewed Sep 30, 2022
View reviewed changes
src/schema/document.rs Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Sep 30, 2022
View reviewed changes
src/schema/document.rs Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Sep 30, 2022
View reviewed changes
src/indexer/merger.rs Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Sep 30, 2022
View reviewed changes
src/indexer/merger.rs Outdated Show resolved Hide resolved
@PSeitz PSeitz force-pushed the ip_field branch 3 times, most recently from 5862f78 to eb00ef6 Compare September 30, 2022 03:12
PSeitz and others added 23 commits October 7, 2022 16:25
@PSeitz
remove comment
6113e04
@PSeitz
use iter api
c8713a0
@PSeitz
fix get_between_vals forwarding
5a76e6c 
fix get_between_vals forwarding in monotonicmapping column by adding an additional conversion function Output->Input
@PSeitz
rename to IpAddr
309449d
@PSeitz
remove null handling
087beaf
@PSeitz
rename to iter_gen
eeb1f19
@PSeitz
remove roaring
f5039f1
@PSeitz
expect instead of unwrap
787a37b
@PSeitz
rename to iter_gen
67f453b
@PSeitz
group montonic mapping and inverse
cdc8e3a 
fix mapping inverse
remove ip indexing
add get_between_vals test
@PSeitz
finalize ip addr rename
4d29ff4
@PSeitz
mark null handling TODO
5d6602a
@PSeitz
rename ip addr, use buffer
0b86658
@PSeitz
remove u128 type
e50e74a
@PSeitz
serialize ip as u128, add test for positions_to_docid
5171ff6
@PSeitz
use serializer for u128
2864bf7
@PSeitz
add StrictlyMonotonicFn
226a493
@PSeitz
enable test
a8a36b6
@PSeitz
improve comment
39f4e58
@PSeitz
add test
9a1609d
@PSeitz
use idx part only for positions_to_docid
96315df
@PSeitz @fulmicoton
Apply suggestions from code review
f465173 
Co-authored-by: Paul Masurel <paul@quickwit.io>
@PSeitz @fulmicoton
use ipv6
534b1d3 
Co-authored-by: Paul Masurel <paul@quickwit.io>
@PSeitz PSeitz merged commit 3650d1f into main Oct 11, 2022
@PSeitz PSeitz deleted the ip_field branch October 11, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PSeitz @codecov-commenter @fulmicoton