Allow for a same-thread doc compressor. #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
same-thread-doc-compressor
branch
from
e3e59a7
to
5602efe
Compare
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 93.96% 93.98% +0.02%
==========================================
Files 242 243 +1
Lines 44936 45089 +153
==========================================
+ Hits 42226 42379 +153
Misses 2710 2710
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
force-pushed
the
same-thread-doc-compressor
branch
3 times, most recently
from
456e0db
to
dbd1ddd
Compare
fulmicoton
force-pushed
the
same-thread-doc-compressor
branch
3 times, most recently
from
f02ff44
to
22b5d11
Compare
PSeitz
reviewed
Sep 8, 2022
| @@ -235,6 +235,14 @@ impl InnerSegmentMeta { | |||
| } | |||
| } | |||
|
|
|||
| fn return_true() -> bool { | |||
There was a problem hiding this comment.
Suggested change
| fn return_true() -> bool { | |
| fn docstore_compress_dedicated_thread() -> bool { |
PSeitz
reviewed
Sep 8, 2022
| /// If set to true, docstore compression will happen on a dedicated thread. | ||
| /// (defaults: true) | ||
| #[doc(hidden)] | ||
| #[serde(default = "return_true")] |
There was a problem hiding this comment.
Suggested change
| #[serde(default = "return_true")] | |
| #[serde(default = "docstore_compress_dedicated_thread")] |
PSeitz
reviewed
Sep 8, 2022
src/store/store_compressor.rs
Outdated
Comment on lines
18
to
20
| enum Impls { | ||
| SameThread(BlockCompressorImpl), | ||
| DedicatedThread(DedicatedThreadBlockCompressorImpl), |
There was a problem hiding this comment.
I think the naming could be improved here a little
Suggested change
| enum Impls { | |
| SameThread(BlockCompressorImpl), | |
| DedicatedThread(DedicatedThreadBlockCompressorImpl), | |
| enum BlockCompressorVariants { | |
| SameThread(SameThreadBlockCompressor), | |
| DedicatedThread(DedicatedThreadBlockCompressor), |
PSeitz
approved these changes
Sep 8, 2022
In addition, it isolates the doc compressor logic, better reports io::Result. In the case of the same-thread doc compressor, the blocks are also not copied.
fulmicoton
force-pushed
the
same-thread-doc-compressor
branch
from
22b5d11
to
d6bd9a9
Compare
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, it isolates the doc compressor logic, better reports io::Result.
In the case of the same-thread doc compressor,
the blocks are also not copied.