New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose doc store cache size #1403
Conversation
97c48bb
to
4f57747
Compare
Codecov Report
@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 94.30% 94.25% -0.06%
==========================================
Files 236 236
Lines 43651 43680 +29
==========================================
+ Hits 41165 41170 +5
- Misses 2486 2510 +24
Continue to review full report at Codecov.
|
that PR is allowing to set the cache size on the docstore. The PR does not really explain why. Could this be done on segment reader creation? |
expose lru doc store cache size optimize doc store cache size
4f57747
to
b5402ea
Compare
b5402ea
to
5750224
Compare
One benefit is to reduce the cache size for merging. The other benefit is to reduce memory consumption for quickwit fetch_docs. The cache size is much more important with the larger blocks now. |
expose lru doc store cache size
optimize doc store cache size