Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make errors cloneable #1402

Merged
merged 1 commit into from Jun 30, 2022
Merged

make errors cloneable #1402

merged 1 commit into from Jun 30, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Jun 30, 2022

make errors cloneable by wrapping io::Error in an Arc

The debouncer experiment showed, that there is some value when errors are Clone. I think it's quite easy to provide that convenience in tantivy

@codecov-commenter
Copy link

Codecov Report

Merging #1402 (a192134) into main (db18366) will decrease coverage by 0.02%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   94.32%   94.30%   -0.03%     
==========================================
  Files         236      236              
  Lines       43640    43658      +18     
==========================================
+ Hits        41165    41171       +6     
- Misses       2475     2487      +12     
Impacted Files Coverage Δ
src/directory/error.rs 1.63% <5.55%> (-0.33%) ⬇️
src/directory/ram_directory.rs 88.81% <33.33%> (ø)
src/directory/directory.rs 90.41% <50.00%> (-3.71%) ⬇️
src/directory/managed_directory.rs 88.88% <66.66%> (+0.63%) ⬆️
src/error.rs 25.39% <66.66%> (+3.36%) ⬆️
src/directory/mmap_directory.rs 91.10% <83.33%> (+0.04%) ⬆️
src/postings/stacker/expull.rs 98.57% <0.00%> (-0.48%) ⬇️
src/fieldnorm/writer.rs 98.48% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db18366...a192134. Read the comment docs.

@PSeitz PSeitz merged commit c127367 into quickwit-oss:main Jun 30, 2022
@PSeitz PSeitz deleted the cloneable_error branch June 30, 2022 12:12
PSeitz added a commit that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants