improve error on missing config #4565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
reviewed
Feb 13, 2024
| @@ -219,7 +219,9 @@ pub fn start_actor_runtimes( | |||
| async fn load_node_config(config_uri: &Uri) -> anyhow::Result<NodeConfig> { | |||
| let config_content = load_file(&StorageResolver::unconfigured(), config_uri) | |||
| .await | |||
| .context("failed to load node config")?; | |||
| .context(r#" | |||
There was a problem hiding this comment.
load_filecan fail for other reasons, we should display this error only on not found errorconfig_uriis not necessarilyquickwit/quickwit.yaml, depending on what was the argument of--configor value ofQW_CONFIG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Error message when we can't find the
quickwit.yamlThis may happen if the quickwit binary is a system package, which is the case with nixOS https://search.nixos.org/packages?query=Quickwit
Currently I think there is no easy one-liner to create a missing config.
It could be added to
quickwit tool init-configmaybe?We could also point to download a config from the gh repo, but there would be the issue with different versions.