Updating to tokio 1.23 and updating unit tests. #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/2571
branch
2 times, most recently
from
0e1c7ac
to
e55d89e
Compare
fulmicoton
force-pushed
the
issue/2571
branch
from
e55d89e
to
a8cf4ab
Compare
fulmicoton
commented
Dec 14, 2022
| @@ -522,7 +523,7 @@ mod tests { | |||
| ); | |||
| // Trigger new plan evaluation and check that we don't have new merge operation. | |||
| delete_planner_mailbox | |||
| .send_message(PlanDeleteOperations) | |||
| .ask(PlanDeleteOperations) | |||
There was a problem hiding this comment.
send message just queues a message and returns. It does not wait for the message to be processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2571