Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove chrono #1243

Merged
merged 1 commit into from Mar 31, 2022
Merged

remove chrono #1243

merged 1 commit into from Mar 31, 2022

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Mar 30, 2022 •
edited

remove chrono

chrono dependency on diesel not removed

@PSeitz PSeitz linked an issue Mar 30, 2022 that may be closed by this pull request
Update quickwit to tantivy main and remove chrono #1232
Closed
@PSeitz PSeitz force-pushed the remove_chrono branch 2 times, most recently from 31a7e27 to ad04dfe Compare March 30, 2022 04:03
@PSeitz PSeitz requested a review from fmassot March 30, 2022 15:04
fmassot
fmassot approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PSeitz PSeitz merged commit 90b8b58 into quickwit-oss:main Mar 31, 2022
@PSeitz PSeitz linked an issue Apr 15, 2022 that may be closed by this pull request
Remove dependency to chrono and use time directly #1296
Closed
@PSeitz PSeitz mentioned this pull request Apr 18, 2022
Merged
@guilload guilload mentioned this pull request Apr 18, 2022
Closed
@PSeitz PSeitz mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency to chrono and use time directly Update quickwit to tantivy main and remove chrono
2 participants
@PSeitz @fmassot