Make the round tripper use the dialer's context #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this addresses the DNS part of #3342 |
| if host, port, err = net.SplitHostPort(addr); err != nil { | ||
| return nil, err | ||
| } | ||
| if portnum, err = net.DefaultResolver.LookupPort(ctx, netstr, port); err != nil { |
There was a problem hiding this comment.
Why is this needed? Why not just use the port? Does it cause a potential DNS roundtrip?
| if host == "" { | ||
| return &net.UDPAddr{IP: net.IPAddr{}.IP, Port: portnum, Zone: net.IPAddr{}.Zone}, nil | ||
| } | ||
| ips, err := net.DefaultResolver.LookupIPAddr(ctx, host) |
There was a problem hiding this comment.
I imagine that this will soon invite a request to use a different resolver here. How shall we deal with that?
|
@deweerdt Are you still planning to work on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is useful in getting https://pkg.go.dev/net/http/httptrace events related to DNS when using the round tripper to make a request. Other events related to the connection continue not to work.