schedule sending when writing initial or handshake crypto data #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change expected. We already did schedule sending for all cases but the ClientHello. Scheduling explicitly allows us to remove this corner case.
marten-seemann
force-pushed
the
crypto-write-schedule-sending
branch
from
57f2c54
to
b0e588d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4268 +/- ##
==========================================
- Coverage 84.78% 84.71% -0.07%
==========================================
Files 152 149 -3
Lines 14344 14090 -254
==========================================
- Hits 12161 11936 -225
+ Misses 1682 1668 -14
+ Partials 501 486 -15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change expected. We already did schedule sending for all cases but the ClientHello. Scheduling explicitly allows us to remove this corner case.