#3851 ping frame added in handshake #3935
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Updated as per PR comments, similar pattern of time consumption for all tests. When lines were commented, it took 116 seconds When lines were not commented, it took 90 seconds on my machine |
packet_packer.go
Outdated
| @@ -331,9 +331,14 @@ func (p *packetPacker) PackCoalescedPacket(onlyAck bool, maxPacketSize protocol. | |||
| initialHdr, initialPayload = p.maybeGetCryptoPacket(maxPacketSize-protocol.ByteCount(initialSealer.Overhead()), protocol.EncryptionInitial, onlyAck, true, v) | |||
| if initialPayload.length > 0 { | |||
| size += p.longHeaderPacketLength(initialHdr, initialPayload, v) + protocol.ByteCount(initialSealer.Overhead()) | |||
|
|
|||
| if size >= maxPacketSize-protocol.MinCoalescedPacketSize { | |||
There was a problem hiding this comment.
This if doesn’t seem correct:
- You’re not allowed to add a PING if
ackOnlyis set. - You should only add a PING if there’s no other frames in the packet.
There was a problem hiding this comment.
You should only add a PING if there’s no other frames in the packet.
is it a bug in our code ? because I confirmed this from rfc9000#section-17.2.2-8 which says
The payload of an Initial packet includes a CRYPTO frame (or frames) containing a cryptographic handshake message, ACK frames, or both. PING, PADDING, and CONNECTION_CLOSE frames of type 0x1c are also permitted.
There was a problem hiding this comment.
Why do you think it’s a bug? All these frames are permitted, but we’re only concerned with the situation where we only happen to have an ACK frame to send.
Ping Frame added when packet is nil and handShake is not confirmed yet.
Commenting this line took 108 seconds to complete all tests
With this line took 82 seconds to complete all tests
