Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ringbuffer in the framer #3874

Closed
wants to merge 1 commit into from
Closed

use ringbuffer in the framer #3874

wants to merge 1 commit into from

Conversation

Glonee
Copy link
Contributor

@Glonee Glonee commented Jun 1, 2023

Fixes #3826. Part of #3526.
I deleted the master branch in my fork by mistake result in the close of #3857. Now the master branch is already an another PR on it so I can't reopen it. Opening an new PR.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #3874 (0c91c74) into master (c96fbd2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3874      +/-   ##
==========================================
+ Coverage   83.83%   83.89%   +0.06%     
==========================================
  Files         146      147       +1     
  Lines       14391    14441      +50     
==========================================
+ Hits        12064    12114      +50     
  Misses       1883     1883              
  Partials      444      444              
Impacted Files Coverage Δ
framer.go 98.10% <100.00%> (-0.02%) ⬇️
internal/utils/ringbuffer/ringbuffer.go 100.00% <100.00%> (ø)

@Glonee Glonee closed this Jun 1, 2023
@Glonee Glonee deleted the ringbuffer branch June 1, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use a ring buffer for the frame queue in the framer
1 participant