pass payload around by value in the packet packer #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.13% // Head: 85.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
- Coverage 85.13% 85.12% -0.00%
==========================================
Files 140 140
Lines 10360 10357 -3
==========================================
- Hits 8819 8816 -3
Misses 1138 1138
Partials 403 403
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Dec 30, 2022
lucas-clemente
approved these changes
Jan 16, 2023
marten-seemann
force-pushed
the
optimize-short-header-packing
branch
from
124ed86
to
e10af24
Compare
marten-seemann
changed the base branch from
optimize-short-header-packing
to
master
marten-seemann
force-pushed
the
optimize-payload-packing
branch
from
94d6bb9
to
e094f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3647. Part of #3526.
This avoids heap allocations, making the respective code path disappear completely in the alloc pprof.