New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http3: handle ErrAbortHandler when the handler panics #3575
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5eb236b
Handle abort like the stdlib does
shade34321 d148d8c
Using the sentinel value from the stdlib instead of redefining.
shade34321 15031b1
we return before logging out
shade34321 c5501cf
Added test to hand abort handler
shade34321 a5091d0
Added in two tests but apparently only saved the first one.
shade34321 0dd041a
remove one test case because it wasn't needed
shade34321 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,6 +201,36 @@ var _ = Describe("Server", func() { | |
Expect(hfs).To(HaveKeyWithValue(":status", []string{"200"})) | ||
}) | ||
|
||
It("handles aborts", func() { | ||
testErr := http.ErrAbortHandler | ||
done := make(chan struct{}) | ||
unknownStr := mockquic.NewMockStream(mockCtrl) | ||
s.UniStreamHijacker = func(st StreamType, _ quic.Connection, str quic.ReceiveStream, err error) bool { | ||
defer close(done) | ||
Expect(st).To(BeZero()) | ||
Expect(str).To(Equal(unknownStr)) | ||
Expect(err).To(MatchError(testErr)) | ||
return true | ||
} | ||
}) | ||
|
||
It("handles a aborting handler", func() { | ||
s.Handler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
panic(http.ErrAbortHandler) | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is supposed to be the more complete test, I wasn't sure how to mock an http abort and this is all I could think of. Is there something better? |
||
|
||
responseBuf := &bytes.Buffer{} | ||
setRequest(encodeRequest(exampleGetRequest)) | ||
str.EXPECT().Context().Return(reqContext) | ||
str.EXPECT().Write(gomock.Any()).DoAndReturn(responseBuf.Write).AnyTimes() | ||
str.EXPECT().CancelRead(gomock.Any()) | ||
|
||
serr := s.handleRequest(conn, str, qpackDecoder, nil) | ||
Expect(serr.err).ToNot(HaveOccurred()) | ||
hfs := decodeHeader(responseBuf) | ||
Expect(hfs).To(HaveKeyWithValue(":status", []string{"500"})) | ||
}) | ||
|
||
It("handles a panicking handler", func() { | ||
s.Handler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
panic("foobar") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just a simple test that I'm not 100% sure is testing what is needed to be tested. But it does test part IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test below this should be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.