Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preallocate the message buffers of the ipv4.Message passed to ReadBatch #3541

Merged
merged 1 commit into from Aug 30, 2022
Merged

preallocate the message buffers of the ipv4.Message passed to ReadBatch #3541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions sys_conn_oob.go
View file
Open in desktop
Expand Up @@ -122,10 +122,15 @@ func newConn(c OOBCapablePacketConn) (*oobConn, error) {
bc = ipv4.NewPacketConn(c)
}

msgs := make([]ipv4.Message, batchSize)
for i := range msgs {
// preallocate the [][]byte
msgs[i].Buffers = make([][]byte, 1)
}
oobConn := &oobConn{
OOBCapablePacketConn: c,
batchConn: bc,
messages: make([]ipv4.Message, batchSize),
messages: msgs,
readPos: batchSize,
}
for i := 0; i < batchSize; i++ {
Expand All @@ -142,7 +147,7 @@ func (c *oobConn) ReadPacket() (*receivedPacket, error) {
buffer := getPacketBuffer()
buffer.Data = buffer.Data[:protocol.MaxPacketBufferSize]
c.buffers[i] = buffer
c.messages[i].Buffers = [][]byte{c.buffers[i].Data}
c.messages[i].Buffers[0] = c.buffers[i].Data
}
c.readPos = 0

Expand Down