Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce a separate code paths for Short Header packet handling #3534

Merged
merged 8 commits into from Aug 30, 2022
Merged

introduce a separate code paths for Short Header packet handling #3534

merged 8 commits into from Aug 30, 2022

Commits on Aug 29, 2022

  1. return an error when parsing a too long connection ID from a header

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f41772c View commit details
    Browse the repository at this point in the history

  2. don't pass the header to connection.tryQueueingUndecryptablePacket

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7d827d5 View commit details
    Browse the repository at this point in the history

  3. remove unneeded packet number field from the unpackedPacket

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    fd1b3a2 View commit details
    Browse the repository at this point in the history

  4. move the check for empty payload to the unpacker

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    e3723a0 View commit details
    Browse the repository at this point in the history

  5. extend ByteOrder interface to allow converting from a byte slice

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    42cec84 View commit details
    Browse the repository at this point in the history

  6. add a wire.ShortHeader, implement short header parsing 

    The new parsing function is vastly faster than the combination of header
and extended header parsing:

BenchmarkShortHeaderParsing-10          44192314                26.79 ns/op           48 B/op          1 allocs/op
BenchmarkShortHeaderParsingOld-10       12627363                99.99 ns/op          228 B/op          3 allocs/op
    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    3a12a89 View commit details
    Browse the repository at this point in the history

  7. split the tracing function for received short and long header packets

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    ed15a94 View commit details
    Browse the repository at this point in the history

  8. introduce a separate code path for unpacking short header packets

    @marten-seemann
    marten-seemann committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4f3d3b3 View commit details
    Browse the repository at this point in the history