Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for bidirectional stream hijacker #3391

Merged

Conversation

hareku
Copy link
Contributor

@hareku hareku commented Apr 23, 2022

This PR adds more tests for #3362.

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #3391 (500085e) into master (1a0d577) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3391      +/-   ##
==========================================
+ Coverage   85.40%   85.63%   +0.23%     
==========================================
  Files         135      135              
  Lines        9911     9911              
==========================================
+ Hits         8464     8487      +23     
+ Misses       1065     1047      -18     
+ Partials      382      377       -5     
Impacted Files Coverage Δ
http3/server.go 74.03% <0.00%> (+1.95%) ⬆️
http3/frames.go 86.30% <0.00%> (+2.74%) ⬆️
http3/client.go 90.32% <0.00%> (+8.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0d577...500085e. Read the comment docs.

@hareku hareku force-pushed the test-bidirectional-stream-hijacker branch 3 times, most recently from 2e3bf25 to e10bed6 Compare April 23, 2022 13:35
@marten-seemann marten-seemann merged commit 897759f into quic-go:master May 27, 2022
@marten-seemann
Copy link
Member

I merged this PR, but it felt our build: https://github.com/lucas-clemente/quic-go/runs/6623712316. I had to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants