Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce flakiness of deadline integration tests #3383

Merged
merged 1 commit into from Apr 25, 2022
Merged

reduce flakiness of deadline integration tests #3383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions integrationtests/self/deadline_test.go
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ var _ = Describe("Stream deadline tests", func() {
server, serverStr, clientStr := setup()
defer server.Close()

const timeout = 20 * time.Millisecond
const timeout = time.Millisecond
done := make(chan struct{})
go func() {
defer GinkgoRecover()
Expand All @@ -75,7 +75,7 @@ var _ = Describe("Stream deadline tests", func() {
bytesRead += n
}
Expect(data).To(Equal(PRDataLong))
// make sure the test actually worked an Read actually ran into the deadline a few times
// make sure the test actually worked and Read actually ran into the deadline a few times
Expect(timeoutCounter).To(BeNumerically(">=", 10))
Eventually(done).Should(BeClosed())
})
Expand All @@ -84,7 +84,7 @@ var _ = Describe("Stream deadline tests", func() {
server, serverStr, clientStr := setup()
defer server.Close()

const timeout = 20 * time.Millisecond
const timeout = time.Millisecond
go func() {
defer GinkgoRecover()
_, err := serverStr.Write(PRDataLong)
Expand Down Expand Up @@ -134,7 +134,7 @@ var _ = Describe("Stream deadline tests", func() {
server, serverStr, clientStr := setup()
defer server.Close()

const timeout = 20 * time.Millisecond
const timeout = time.Millisecond
done := make(chan struct{})
go func() {
defer GinkgoRecover()
Expand Down Expand Up @@ -167,7 +167,7 @@ var _ = Describe("Stream deadline tests", func() {
server, serverStr, clientStr := setup()
defer server.Close()

const timeout = 20 * time.Millisecond
const timeout = time.Millisecond
readDone := make(chan struct{})
go func() {
defer GinkgoRecover()
Expand Down