Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): re-enable test timeouts with working code coverage #2102

Merged
merged 5 commits into from
May 10, 2022

Conversation

bziobrowski
Copy link
Contributor

Updating junit to 4.13.2 fixed the coverage issue .

@jerrinot
Copy link
Contributor

jerrinot commented May 9, 2022

@bziobrowski do you know what change in Junit fixes the Jacoco issues? Is it this one? junit-team/junit4#1517

@bziobrowski
Copy link
Contributor Author

It was one of those mentioned at https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.2.md

Copy link
Contributor

@jerrinot jerrinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is very little to lose and the best is just to try it out.

@bluestreak01 bluestreak01 merged commit 5450729 into master May 10, 2022
@bluestreak01 bluestreak01 deleted the reenable_test_timeouts branch May 10, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants