Overhaul the execution graph API. #986
Open
+440
−380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubyte
force-pushed
the
execution-graph-overhaul
branch
from
05c4fa8
to
74a4b19
Compare
qubyte
force-pushed
the
execution-graph-overhaul
branch
from
74a4b19
to
0833d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still more to do here. I think I can drop using string names completely, and have graph nodes directly refer to each other by reference. The
GraphNodecontext could be populated with the names and resolved return values of its dependencies. It's probably possible to fully type everything this way with only JSDoc annotations.