chore: Bump golang to 1.17 (PROJQUAY-2781) #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
suggested changes
Jan 14, 2022
There was a problem hiding this comment.
You gonna have to run "go mod tidy" before sending up this PR (otherwise the CI is going to fail). Could you assign this PR to https://issues.redhat.com/browse/PROJQUAY-2781 ? Make sure that the Jira card points to 3.7.0
harishsurf
force-pushed
the
bump-go
branch
2 times, most recently
from
797aa59
to
dd692a1
Compare
harishsurf
changed the title
Fixes failing "go build" since the reflect pkg was updated to include isExported() with go v1.17 Signed-off-by: harishsurf <hgovinda@redhat.com>
ricardomaraschini
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go build main.gois failing with:causing our CI to fail. The issue is fixed by bumping golang version to
1.17.See here for details
Signed-off-by: harishsurf hgovinda@redhat.com