Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go on CI #457

Closed
wants to merge 1 commit into from
Closed

Bump Go on CI #457

wants to merge 1 commit into from

Conversation

cristaloleg
Copy link
Collaborator

No description provided.

@ldez
Copy link
Contributor

ldez commented Aug 9, 2023

🤔 Seems similar to #451

@cristaloleg
Copy link
Collaborator Author

Yep

@liggitt
Copy link
Contributor

liggitt commented Aug 10, 2023

I think the lint target is failing because it is using the v1.49.0 version of golangci/golangci-lint, which is built with v0.3.17 of this library (https://github.com/golangci/golangci-lint/blob/v1.49.0/go.mod#L159), which doesn't have the fix for go1.21

Ironically, to get go-ruleguard CI working with go1.21, I think you'll need to:

  1. tag a go-ruleguard release
  2. update golangci-lint to use the new tagged go-ruleguard release
  3. tag a golangci-lint release
  4. update go-ruleguard CI to use the new tagged golangci-lint release and update nested go.mod files (dsl, rules, cmd/gorules) to reference the tagged fixed go-ruleguard release

I guess that's what happens when we have circular dependencies on ourselves in tools we use for presubmit CI :)

@cristaloleg
Copy link
Collaborator Author

We've https://github.com/quasilyte/go-ruleguard/releases/tag/v0.3.20 now.

@cristaloleg
Copy link
Collaborator Author

circular dependencies

or just disable golangci-lint here, verify that golangci-lint can be built with ruleguard v0.3.20. WDYT ?

@cristaloleg
Copy link
Collaborator Author

Done in #451

@cristaloleg cristaloleg deleted the cristaloleg-patch-1 branch August 10, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants