Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use correct list type for QSliderSlots (fix: #17060) #17061

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

thexeos
Copy link
Contributor

@thexeos thexeos commented Mar 30, 2024

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

This fixes #17060

Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index 15e8dba..56d1c60 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -555,7 +555,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -654,7 +654,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
diff --git a/./current-build/api/QSlider.json b/./pr-build/api/QSlider.json
index b672eea..e4393f9 100644
--- a/./current-build/api/QSlider.json
+++ b/./pr-build/api/QSlider.json
@@ -450,7 +450,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -549,7 +549,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index fcc4fb0..ab06fc4 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -8209,7 +8209,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -8233,7 +8233,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9879,7 +9879,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9903,7 +9903,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -14591,7 +14591,6 @@ import { QInputNativeElement } from "./api";
 import { QPopupProxyInnerComponent } from "./api";
 import { SliderMarkerLabels } from "./api";
 import { SliderMarkerLabelConfig } from "./api";
-import { SliderMarkerLabelArrayConfig } from "./api";
 import { SliderMarkerLabelObjectConfig } from "./api";
 import { QTreeNode } from "./api";
 import { QUploaderFactoryFn } from "./api";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect TS type for markerList of QSliderSlots
1 participant