Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): correctly apply iOS safe area padding when using q-tabs #17055

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

yusufkandemir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Maybe: if the users patched the safe area themselves because the builtin solution wasn't working, this might break their apps depending on the element they applied padding

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)

Other information:
.q-tabs-head seems to be left from v0.17, it's now .q-tabs__content

.q-tabs:last-child doesn't work when using the elevated prop of q-footer, as the last child of the footer becomes the layout shadow div. So, fortified the selector to work regardless of whether the footer is elevated or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant