Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QField Event propagation for label tag property #17035

Closed
wants to merge 3 commits into from

Conversation

ahmedjas1m
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QField.json b/./pr-build/api/QField.json
index 813c251..6d33035 100644
--- a/./current-build/api/QField.json
+++ b/./pr-build/api/QField.json
@@ -280,7 +280,7 @@
         "label"
       ],
       "category": "content",
-      "default": "label",
+      "default": "div",
       "addedIn": "v2.13.1",
       "required": false
     }

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 2d75bf5..5c4a7e1 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -4961,7 +4961,7 @@ export interface QFieldProps {
   maxlength?: string | number | undefined;
   /**
    * HTML tag to use
-   * Default value: label
+   * Default value: div
    */
   tag?: string | undefined;
   /**

@ahmedjas1m ahmedjas1m closed this by deleting the head repository Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant