Docs: Updated "Electron Accessing Files" to be more beginner friendly #16276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a beginner reading the document it was very confusing that i followed and did exactly what the document was telling me to do in order to achieve Reading and Writing Files through electron, but the document missed on some steps which are covered in "Frameless Electron Window" document so i just added those parts in here these are my changes : ### Setting up @electron/remote window installing @electron/remote and adding it to dependencies setting it up in main.js and preload.js
Sepehr0011
changed the title
Sepehr0011
changed the title
|
sorry for editing the title, im new to Pull Requests in general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information:
as a beginner following the document to access files through Electron, it was very confusing and i would run into alot of errors because the document didn't have some steps that are required, those steps are in other part of the documentation namely "Frameless Electron Window" document which comes after this doc
so i just added those required steps in here :
Setting up @electron/remote window
installing @electron/remote and adding it to dependencies
setting it up in main.js and preload.js
the rest of the document is unchanged