Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QCircularProgress): border of the rounded arc #16146

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

bazuka5801
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
Added arc stroke (works only when rounded === true)

@bazuka5801
Copy link
Contributor Author

Screenshots

image
image

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QCircularProgress.json b/./pr-build/api/QCircularProgress.json
index b69592c..8f9a2a6 100644
--- a/./current-build/api/QCircularProgress.json
+++ b/./pr-build/api/QCircularProgress.json
@@ -87,6 +87,24 @@
       "category": "style",
       "addedIn": "v2.8.4"
     },
+    "borderWidth": {
+      "type": "Number",
+      "desc": "(Only works if rounded === true) Width of progress arc boundary",
+      "default": 0,
+      "category": "style",
+      "required": false
+    },
+    "borderColor": {
+      "type": "String",
+      "tsType": "NamedColor",
+      "desc": "Color name for the the arc progress boundary from the Quasar Color Palette",
+      "examples": [
+        "primary",
+        "teal",
+        "teal-10"
+      ],
+      "category": "style"
+    },
     "thickness": {
       "type": "Number",
       "default": 0.2,

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index aea0d49..34ae9b6 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -3400,6 +3400,14 @@ export interface QCircularProgressProps {
    * Rounding the arc of progress
    */
   rounded?: boolean | undefined;
+  /**
+   * (Only works if rounded === true) Width of progress arc boundary
+   */
+  borderWidth?: number | undefined;
+  /**
+   * Color name for the the arc progress boundary from the Quasar Color Palette
+   */
+  borderColor?: NamedColor | undefined;
   /**
    * Thickness of progress arc as a ratio (0.0 < x < 1.0) of component size
    * Default value: 0.2

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

UI Tests Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
2 files    0
2 errors

For more details on these parsing errors, see this check.

Results for commit a70b4f3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant