Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui, cypress): fix linting errors #15782

Merged
merged 2 commits into from
May 8, 2023
Merged

test(ui, cypress): fix linting errors #15782

merged 2 commits into from
May 8, 2023

Conversation

freddy38510
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@freddy38510
Copy link
Contributor Author

freddy38510 commented May 3, 2023

I don't know exactly why the tests fail. It seems that the commit is not taken into account, which could be related to the cache.

I have successfully run the UI tests in my forked repo. The results are also available on Cypress Cloud.

@IlCallo
Copy link
Member

IlCallo commented May 8, 2023

Our workflow CI is currently a bit messed up and runs on the existing dev branch instead of the new PRs commits, due to how Cypress Cloud works.
We're working to fix that and drop Cypress Cloud reports to make it behave correctly, sorry for the confusion

@IlCallo IlCallo merged commit 7276344 into quasarframework:dev May 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants