Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): update webpack-dev-server to v4.0.0-rc.0 #10289

Closed
wants to merge 1 commit into from

Conversation

hawkeye64
Copy link
Member

The only issue I saw is handling for this which may need extra tweaking:

The only issue I saw is handling for this which may need extra tweaking:
- host and port options can't be null or empty string
https://github.com/webpack/webpack-dev-server/releases/tag/v4.0.0-rc.0
@LeoniePhiline
Copy link

Yes! This update is dearly needed.

Right now, neither the old nor the new option validate successfully:

Old:

  devServer: {
    sockPort: 443,
  },

(This fails, because sockPort no longer validates.)

New:

  devServer: {
    webSocketURL: {
      port: 443,
    },
  },

(This fails, because webSocketURL does not validate in webpack-dev-server@4-beta, but that is fixed in rc.0.)

See also: https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md

@LeoniePhiline
Copy link

@hawkeye64 Why did you close the PR?

@therealcoder1337
Copy link

@LeoniePhiline i guess because more work is needed, as i outlined in #10083 (comment) and #10083 (comment)
simply bumping the dependency will not help, because of needed migration steps.

@LeoniePhiline
Copy link

Ah I see. Thank you!

@hawkeye64 hawkeye64 deleted the webpack-dev-server branch October 4, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants