Dev UI: Replaced internal components with Qomponent #40615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
This comment has been minimized.
This comment has been minimized.
cescoffier
requested changes
May 14, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
|
@cescoffier should be good now |
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
cescoffier
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we moved the internal web components create and used by Dev UI to an external project, called Qomponent , so that it can be used outside of Dev UI. This PR changes Dev UI to use the new components. It also adds the concepts of "relocations" for namespaces, so that code that still import the internal component, will now use qomponent (without having to change).
This also use a new version of code-block, that fixed the theme switching bug. Now when you are on a page that has a code block, switching theme will also change the code-mirror theme to the matching theme.