Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper Openshift annotation for VCS #29874

Merged
merged 1 commit into from Dec 19, 2022
Merged

Use proper Openshift annotation for VCS #29874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/src/main/asciidoc/deploying-to-kubernetes.adoc
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@ The full source of the `kubernetes.json` file looks something like this:
"kind" : "Deployment",
"metadata" : {
"annotations": {
"app.quarkus.io/vcs-url" : "<some url>",
"app.quarkus.io/vcs-uri" : "<some url>",
"app.quarkus.io/commit-id" : "<some git SHA>",
},
"labels" : {
Expand Down Expand Up @@ -123,7 +123,7 @@ The full source of the `kubernetes.json` file looks something like this:
"kind" : "Service",
"metadata" : {
"annotations": {
"app.quarkus.io/vcs-url" : "<some url>",
"app.quarkus.io/vcs-uri" : "<some url>",
"app.quarkus.io/commit-id" : "<some git SHA>",
},
"labels" : {
Expand Down Expand Up @@ -305,7 +305,7 @@ Out of the box, the generated resources will be annotated with version control r
[source,json]
----
"annotations": {
"app.quarkus.io/vcs-url" : "<some url>",
"app.quarkus.io/vcs-uri" : "<some url>",
"app.quarkus.io/commit-id" : "<some git SHA>",
}
----
Expand Down Expand Up @@ -1065,7 +1065,7 @@ The full source of the `knative.json` file looks something like this:
"kind" : "Service",
"metadata" : {
"annotations": {
"app.quarkus.io/vcs-url" : "<some url>",
"app.quarkus.io/vcs-uri" : "<some url>",
"app.quarkus.io/commit-id" : "<some git SHA>"
},
"labels" : {
Expand Down
2 changes: 1 addition & 1 deletion ...bernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/Constants.java
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ public final class Constants {
static final String QUARKUS = "quarkus";

static final String QUARKUS_ANNOTATIONS_COMMIT_ID = "app.quarkus.io/commit-id";
static final String QUARKUS_ANNOTATIONS_VCS_URL = "app.quarkus.io/vcs-url";
static final String QUARKUS_ANNOTATIONS_VCS_URL = "app.quarkus.io/vcs-uri";
static final String QUARKUS_ANNOTATIONS_BUILD_TIMESTAMP = "app.quarkus.io/build-timestamp";

public static final String HTTP_PORT = "http";
Expand Down