Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent false warning message about missing 'quarkus.debug.print-startup-times' #29855

Merged
merged 1 commit into from Dec 14, 2022
Merged

Prevent false warning message about missing 'quarkus.debug.print-startup-times' #29855

merged 1 commit into from Dec 14, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 14, 2022

No description provided.

@geoand geoand requested a review from gastaldi December 14, 2022 12:25
@geoand
Copy link
Contributor Author

geoand commented Dec 14, 2022

cc @metacosm who first came across this

@gastaldi
Copy link
Contributor

Shouldn't this class mean to be used somewhere?

@geoand
Copy link
Contributor Author

geoand commented Dec 14, 2022 •
edited

It can't be used because the reading of the property occurs too early in the Quarkus boot phase

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 14, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 14, 2022

Failing Jobs - Building 8fb55fb

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
⌛ JVM Tests - JDK 18 Build ⚠️ Check → Logs Raw logs

@geoand geoand merged commit b5576e1 into quarkusio:main Dec 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 14, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 14, 2022
@geoand geoand deleted the printStartupTime branch December 16, 2022 06:05
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geoand @gastaldi @gsmet