Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @ServerRequestFilter(withBody) in favour of @WithFormRead #29825

Merged
merged 1 commit into from Dec 13, 2022
Merged

Deprecate @ServerRequestFilter(withBody) in favour of @WithFormRead #29825

merged 1 commit into from Dec 13, 2022

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Dec 13, 2022

You can also place it on endpoint methods.
Fixes #22444

@FroMage FroMage requested a review from geoand December 13, 2022 10:08
@FroMage FroMage mentioned this pull request Dec 13, 2022
Closed
geoand
geoand approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 13, 2022
@FroMage FroMage merged commit f256c11 into quarkusio:main Dec 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 13, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 13, 2022
@FroMage
Copy link
Member Author

FroMage commented Dec 13, 2022

Since this is a prerequisite for #29763 and that's an important fix, we should backport this to 2.15

@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
@csotiriou csotiriou mentioned this pull request Mar 13, 2023
Open
@csotiriou
Copy link

csotiriou commented Mar 13, 2023 •
edited

@FroMage Would this work with content types other than form, like application/json or text/xml ? So far it seems to be working only with form data in my case. What is the intended behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/resteasy-reactive kind/enhancement New feature or request
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

RESTEasy Reactive: make body-reading filters force reading the body
4 participants
@FroMage @csotiriou @geoand @gsmet