AddNamespaceDecorator doesn't override already set namespaces #29813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
See the message from the bot for how to fix the formatting problem |
|
I force pushed a formatting fix. |
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this pull request
Dec 14, 2022
#456) We need to make sure we run after `AddNamespaceDecorator` because that decorator will overwrite any namespaces we might have set on our `RoleBindings` if we let it run after our own decorator. Proper behavior for the `AddNamespaceDecorator` should be to not overwrite namespaces if they have been set. This has been fixed in quarkusio/quarkus#29813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29809