Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize default ci.yml a bit #29800

Merged
merged 1 commit into from Dec 13, 2022
Merged

Modernize default ci.yml a bit #29800

merged 1 commit into from Dec 13, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 12, 2022

Created as draft to get a CI run in my fork.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 12, 2022
@gsmet gsmet marked this pull request as ready for review December 13, 2022 10:11
@gsmet gsmet requested a review from gastaldi December 13, 2022 10:12
gastaldi
gastaldi approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one small suggestion

...in/resources/codestarts/quarkus/tooling/github-action/base/.github/workflows/ci.tpl.qute.yml Show resolved Hide resolved
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2022

Failing Jobs - Building c7800e3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit cdd60a2 into quarkusio:main Dec 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 13, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 13, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsmet @gastaldi