Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quarkus.knative.image-pull-policy property #29792

Merged
merged 1 commit into from Dec 12, 2022
Merged

Fix quarkus.knative.image-pull-policy property #29792

merged 1 commit into from Dec 12, 2022

Conversation

Sgitario
Copy link
Contributor

Plus, this pull request also verifies that #23832 is fixed.
Fix #23832

@Sgitario
Fix quarkus.knative.image-pull-policy property
3b8f8c9 
Plus, this pull request also verifies that quarkusio#23832 is fixed.
Fix quarkusio#23832
@Sgitario
Copy link
Contributor Author

@iocanel the new test is based on what you did in this commit: 327520d

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 12, 2022

Failing Jobs - Building 3b8f8c9

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

iocanel
iocanel approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sgitario Sgitario merged commit 78397f4 into quarkusio:main Dec 12, 2022
@Sgitario Sgitario deleted the 23832 branch December 12, 2022 10:42
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 12, 2022
@gsmet
Copy link
Member

gsmet commented Dec 12, 2022

@Sgitario should we backport to 2.15?

@Sgitario
Copy link
Contributor Author

Yes, I think we can safely backport it.

@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes kind/bugfix
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

Knative: Property quarkus.knative.revision-auto-scaling.container-concurrency is ignored
3 participants
@Sgitario @gsmet @iocanel