Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent repeated processing of the same authentication failure exception #29365

Merged

Conversation

michalvavrik
Copy link
Contributor

addresses: #29342 (comment)

When debugging linked comment, I mentioned authentication failure is failed twice, first time by the default auth failure handler and then, by the permission check throwable consumer here https://github.com/quarkusio/quarkus/blob/main/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/security/HttpAuthorizer.java#L142. When failed event is failed with the same exception, failure handler chain is applied second time and exception mapper is invoked second time. It didn't really cause an issue for what I could see, but it's not desirable and might be related to the linked test failure (that I couldn't reproduce a single time).

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 19, 2022

Failing Jobs - Building 2daf961

Status Name Step Failures Logs Raw logs
Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/reactive-messaging-kafka 

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testPets - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '21661'. Exit code is: '1'.
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:337)
	at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:110)

@sberyozkin sberyozkin merged commit b3f787e into quarkusio:main Nov 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 19, 2022
@michalvavrik michalvavrik deleted the feature/dont-fail-event-twice branch November 19, 2022 21:45
@gsmet gsmet modified the milestones: 2.15.0.CR1, 2.14.3.Final Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants