Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OIDC propagation annotation to oidc-client #29147

Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Nov 9, 2022

This PR is a follow up to #29130 and is about making it possible to register the oidc-token-propagation-reactive filter the same way it is current possible for the oidc-token-propagation filter, using a common @AccessToken annotation without having to use @RegisterProvider and a complete filter class name, similar to what has been done with oidc-client-reactive-filter with these commits: #28451 and #28472

  • @AccessToken is moved from oidc-token-propagation down to oidc-client
  • oidc-token-propagation-reactive has been updated to support @AccessToken
  • oidc-token-propagation-reactive test has been updated to show the difference

CC @rsvoboda @geoand

Quarkus Documentation automation moved this from To do to Reviewer approved Nov 9, 2022
@sberyozkin
Copy link
Member Author

Thanks

@sberyozkin sberyozkin merged commit 785c23a into quarkusio:main Nov 9, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Nov 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 9, 2022
@sberyozkin sberyozkin deleted the oidc_token_prop_reactive_annotation branch November 9, 2022 13:35
@rsvoboda
Copy link
Member

Thanks @sberyozkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants