Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all implementation of ExtensionAdapter in k8s client extension #29100

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 7, 2022

Fixes: #29096

@geoand
Copy link
Contributor Author

geoand commented Nov 7, 2022

cc @manusa

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 7, 2022

Failing Jobs - Building 98f02aa

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.QuarkusPluginFunctionalTest.canDetectClasspathChangeWhenBuilding line 98 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

io.quarkus.gradle.QuarkusPluginFunctionalTest.canDetectUpToDateBuild line 58 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

@geoand
Copy link
Contributor Author

geoand commented Nov 9, 2022

@iocanel can you take a look at this one?

It would be nice to get it into the next 2.14 release.

Thanks

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

@geoand
Copy link
Contributor Author

geoand commented Nov 9, 2022

Thanks for the review

@geoand geoand merged commit 02c6ff1 into quarkusio:main Nov 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 9, 2022
@manusa
Copy link
Contributor

manusa commented Nov 9, 2022

cc @manusa

Hi @geoand sorry for the late reply 😓

This one looks OK.

However, maybe we want to do:

serviceProviderProducer.produce(ServiceProviderBuildItem.allProvidersFromClassPath(ExtensionAdapter.class.getName()));

for the HttpClient.Factory.class class too.

Regarding this option ServiceProviderBuildItem.allProvidersFromClassPath, I learned about this on this PR. I assume this will discover any SPI provider that's available on the application's compile classpath.

If so, this will be very handy once we merge and release fabric8io/kubernetes-client#4511

@geoand
Copy link
Contributor Author

geoand commented Nov 9, 2022

@manusa thanks for the info. Feel free to send a PR updating the k8s client support

@geoand geoand deleted the #29096 branch November 9, 2022 13:35
@manusa
Copy link
Contributor

manusa commented Nov 9, 2022

👍 Will do. I'll probably tackle everything once we release Kubernetes Client 6.3.0 with the mentioned improvement (hopefully next week 🤞)

@geoand
Copy link
Contributor Author

geoand commented Nov 9, 2022

👌

@gsmet
Copy link
Member

gsmet commented Dec 14, 2022

Actually, this can't be backported to 2.13 as io.fabric8.kubernetes.client.extension.ExtensionAdapter is a new thing in Kubernetes Client 6.x and 2.13 is still using 5.x.

@gsmet
Copy link
Member

gsmet commented Dec 14, 2022

Ah no, actually, it's there but in a different package. I will adjust the package in the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider io.fabric8.knative.client.KnativeExtensionAdapter not found
4 participants