Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-client-bom from 6.1.1 to 6.2.0 #28710

Merged
merged 1 commit into from Oct 24, 2022

Conversation

manusa
Copy link
Contributor

@manusa manusa commented Oct 20, 2022

Kubernetes Client 6.2.0 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.2.0

Just speeding up the dependabot process to see if CI reports any issue.

/cc @metacosm

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Oct 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@manusa manusa changed the title deps: Bump kubernetes-client-bom from 6.1.1 to 6.2.0 Bump kubernetes-client-bom from 6.1.1 to 6.2.0 Oct 20, 2022
@@ -151,7 +151,7 @@
<kotlin.version>1.7.20</kotlin.version>
<kotlin.coroutine.version>1.6.4</kotlin.coroutine.version>
<kotlin-serialization.version>1.4.1</kotlin-serialization.version>
<kubernetes-client.version>6.1.1</kubernetes-client.version> <!-- Please check with Java Operator SDK team before updating -->
<kubernetes-client.version>6.2.0</kubernetes-client.version> <!-- Please check with Java Operator SDK team before updating -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you will have to rebase as I just merged a Dekorate bump. I tried to do it but I can't push to your fork because you have this weird org setup :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, Done :)

you have this weird org setup :).

Yes, I'm using this to better organize the repos in my profile. However, last month I realized (Ioannis shared this) that this won't work well for PRs since I can't let maintainers access my branches :( If someone knows of a better alternative, please share ;)

@geoand
Copy link
Contributor

geoand commented Oct 20, 2022

Seems like there are a lot of failures

@manusa
Copy link
Contributor Author

manusa commented Oct 20, 2022

I couldn't check all the errors, but the first one I saw is bad.

It looks like a misalignment (once again of Dekorate and Fabric8).

2022-10-20T12:15:45.7500626Z Caused by: java.lang.NoSuchMethodError: 'io.fabric8.kubernetes.api.model.BaseKubernetesListFluent io.fabric8.kubernetes.api.model.KubernetesListBuilder.addToItems(io.fabric8.kubernetes.api.model.HasMetadata[])'
2022-10-20T12:15:45.7501495Z 	at io.dekorate.ResourceRegistry.add(ResourceRegistry.java:113)
2022-10-20T12:15:45.7502182Z 	at io.dekorate.AbstractKubernetesManifestGenerator.initializeRegistry(AbstractKubernetesManifestGenerator.java:330)
2022-10-20T12:15:45.7503043Z 	at io.dekorate.kubernetes.manifest.KubernetesManifestGenerator.generate(KubernetesManifestGenerator.java:86)
2022-10-20T12:15:45.7503856Z 	at io.dekorate.kubernetes.manifest.KubernetesManifestGenerator.generate(KubernetesManifestGenerator.java:59)
2022-10-20T12:15:45.7504480Z 	at io.dekorate.Session.lambda$generate$16(Session.java:369)
2022-10-20T12:15:45.7504950Z 	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
2022-10-20T12:15:45.7505565Z 	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
2022-10-20T12:15:45.7506135Z 	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
2022-10-20T12:15:45.7506691Z 	at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
2022-10-20T12:15:45.7507323Z 	at java.base/java.util.concurrent.ConcurrentHashMap$ValueSpliterator.forEachRemaining(ConcurrentHashMap.java:3612)
2022-10-20T12:15:45.7507963Z 	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
2022-10-20T12:15:45.7508552Z 	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2022-10-20T12:15:45.7509146Z 	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
2022-10-20T12:15:45.7509712Z 	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
2022-10-20T12:15:45.7510264Z 	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2022-10-20T12:15:45.7510909Z 	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
2022-10-20T12:15:45.7511596Z 	at io.dekorate.Session.generate(Session.java:363)
2022-10-20T12:15:45.7512016Z 	at io.dekorate.Session.lambda$generate$5(Session.java:292)
2022-10-20T12:15:45.7512414Z 	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
2022-10-20T12:15:45.7512818Z 	at io.dekorate.Session.generate(Session.java:292)
2022-10-20T12:15:45.7513202Z 	at io.dekorate.Session.close(Session.java:256)
2022-10-20T12:15:45.7513743Z 	at io.quarkus.kubernetes.deployment.KubernetesProcessor.lambda$build$2(KubernetesProcessor.java:186)
2022-10-20T12:15:45.7514322Z 	at java.base/java.util.Optional.ifPresent(Optional.java:178)
2022-10-20T12:15:45.7514886Z 	at io.quarkus.kubernetes.deployment.KubernetesProcessor.build(KubernetesProcessor.java:139)
2022-10-20T12:15:45.7515597Z 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
2022-10-20T12:15:45.7516168Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
2022-10-20T12:15:45.7516651Z 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
2022-10-20T12:15:45.7517143Z 	at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
2022-10-20T12:15:45.7517596Z 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
2022-10-20T12:15:45.7518132Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
2022-10-20T12:15:45.7518721Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
2022-10-20T12:15:45.7519208Z 	at java.base/java.lang.Thread.run(Thread.java:833)
2022-10-20T12:15:45.7519602Z 	at org.jboss.threads.JBossThread.run(JBossThread.java:501)

The BaseKubernetesList class (internal) has been removed (fabric8io/kubernetes-client#4499 / fabric8io/kubernetes-client#3906) from the Client, and it looks like Dekorate's fluent types are expecting the class.

Just like last time, I think we'll only be able to merge this one if Dekorate is updated too.

@iocanel @metacosm

@quarkus-bot

This comment has been minimized.

@manusa
Copy link
Contributor Author

manusa commented Oct 21, 2022

Just updated the PR with the latest Dekorate version that has an aligned version of the Fabric8 client 🤞

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Oct 21, 2022

The k8s test failures are suspicious

@manusa
Copy link
Contributor Author

manusa commented Oct 21, 2022

😓 I'll check first thing tomorrow

@manusa manusa force-pushed the deps/kubernetes-client branch 4 times, most recently from 61831ee to 5e1b5bd Compare October 22, 2022 05:48
@manusa
Copy link
Contributor Author

manusa commented Oct 22, 2022

The tests should be passing now.

Note that I realized we weren't doing any sort of Native image processing for the openshift-client extension.
I added a step to register the OpenShift client, its service providers, and the Java model types. I'm unsure how people were actually able to consume or make use of the OpenShift Java model types in native mode right now.

@quarkus-bot

This comment has been minimized.

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2022

Failing Jobs - Building ca923e0

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
🚫 JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

@geoand
Copy link
Contributor

geoand commented Oct 24, 2022

@metacosm any last comments?

@metacosm
Copy link
Contributor

I think that's good for now… the big thing is to get 6.2 in there, we can adjust later on if needed.

@geoand geoand merged commit 879a95a into quarkusio:main Oct 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 24, 2022
@metacosm
Copy link
Contributor

Thank you!

@geoand
Copy link
Contributor

geoand commented Oct 24, 2022

💪

@manusa manusa deleted the deps/kubernetes-client branch December 12, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants