New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-client-bom from 6.1.1 to 6.2.0 #28710
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
@@ -151,7 +151,7 @@ | |||
<kotlin.version>1.7.20</kotlin.version> | |||
<kotlin.coroutine.version>1.6.4</kotlin.coroutine.version> | |||
<kotlin-serialization.version>1.4.1</kotlin-serialization.version> | |||
<kubernetes-client.version>6.1.1</kubernetes-client.version> <!-- Please check with Java Operator SDK team before updating --> | |||
<kubernetes-client.version>6.2.0</kubernetes-client.version> <!-- Please check with Java Operator SDK team before updating --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you will have to rebase as I just merged a Dekorate bump. I tried to do it but I can't push to your fork because you have this weird org setup :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, Done :)
you have this weird org setup :).
Yes, I'm using this to better organize the repos in my profile. However, last month I realized (Ioannis shared this) that this won't work well for PRs since I can't let maintainers access my branches :( If someone knows of a better alternative, please share ;)
af581b9
to
b96ea1c
Compare
Seems like there are a lot of failures |
I couldn't check all the errors, but the first one I saw is bad. It looks like a misalignment (once again of Dekorate and Fabric8).
The BaseKubernetesList class (internal) has been removed (fabric8io/kubernetes-client#4499 / fabric8io/kubernetes-client#3906) from the Client, and it looks like Dekorate's fluent types are expecting the class. Just like last time, I think we'll only be able to merge this one if Dekorate is updated too. |
This comment has been minimized.
This comment has been minimized.
b96ea1c
to
75fdfbd
Compare
Just updated the PR with the latest Dekorate version that has an aligned version of the Fabric8 client 🤞 |
This comment has been minimized.
This comment has been minimized.
The k8s test failures are suspicious |
😓 I'll check first thing tomorrow |
61831ee
to
5e1b5bd
Compare
The tests should be passing now. Note that I realized we weren't doing any sort of Native image processing for the openshift-client extension. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Marc Nuri <marc@marcnuri.com>
5e1b5bd
to
ca923e0
Compare
@metacosm any last comments? |
I think that's good for now… the big thing is to get 6.2 in there, we can adjust later on if needed. |
Thank you! |
💪 |
Kubernetes Client 6.2.0 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.2.0
Just speeding up the dependabot process to see if CI reports any issue.
/cc @metacosm