Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid NPE in Mongo code when connecting on windows #28608

Merged
merged 1 commit into from Oct 18, 2022
Merged

Avoid NPE in Mongo code when connecting on windows #28608

merged 1 commit into from Oct 18, 2022

Conversation

Liuigi
Copy link
Contributor

@Liuigi Liuigi commented Oct 14, 2022 •
edited by geoand

In systems with no /etc/resolv.conf, we need to make sure no NPE is thrown.

Fixes #28607

@quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Oct 17, 2022

Thanks for the PR!

Is this meant to fix #28607?

@geoand geoand changed the title fix: 🐛 avoid NPE when connect on windows Avoid NPE in Mongo code when connect on windows Oct 17, 2022
@geoand geoand changed the title Avoid NPE in Mongo code when connect on windows Avoid NPE in Mongo code when connecting on windows Oct 17, 2022
@Liuigi
Copy link
Contributor Author

Liuigi commented Oct 17, 2022

Thanks for the PR!

Is this meant to fix #28607?

yes that the issue !

@geoand
Copy link
Contributor

geoand commented Oct 17, 2022

Great!

Please squash the commits and rebase you pull request onto main.

Thanks

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jakarta area/maven area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy-reactive area/spring Issues relating to the Spring integration labels Oct 17, 2022
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Oct 17, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented Oct 17, 2022

I rebased to get rid of the merge commit and applied our formatting rules (you can apply them with mvn process-sources).

@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Oct 18, 2022

Force pushed to fix a missing import

Quarkus Documentation automation moved this from To do to Reviewer approved Oct 18, 2022
@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/documentation area/panache area/gradle Gradle area/core area/maven area/amazon-lambda area/spring Issues relating to the Spring integration area/platform Issues related to definition and interaction with Quarkus Platform area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/resteasy-reactive area/jakarta labels Oct 18, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@Liuigi @geoand
fix: 🐛 avoid NPE when connect on windows
06ff785 
or with no access to the conf file : /etc/resolv.conf
@geoand geoand merged commit d0cda08 into quarkusio:main Oct 18, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 18, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 18, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 18, 2022
@Liuigi Liuigi deleted the patch-1 branch October 20, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/mongodb kind/bugfix
Projects
Quarkus Documentation
Done
Milestone
2.13.3.Final
Development

Successfully merging this pull request may close these issues.

MongoDb Srv connection does not work on windows
3 participants
@Liuigi @geoand @gsmet