Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the guides #28606

Merged
merged 1 commit into from Oct 17, 2022
Merged

Clean up the guides #28606

merged 1 commit into from Oct 17, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 14, 2022

  • Remove outdated content
  • Rename includes/ to _includes/ so that it does not get rendered
  • Move all includes to the _includes/ subdirectory

@ebullient see the description here ^
It's really basic cleanup but it should avoid us having rules to ignore random files all over the place.

@gsmet gsmet requested a review from ebullient October 14, 2022 16:03
@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Oct 14, 2022
@gsmet gsmet force-pushed the cleanup-docs branch 2 times, most recently from 569603b to ed85f00 Compare October 17, 2022 15:15
@@ -14,7 +14,7 @@ high availability with no single point of failure.

In this guide, we will see how you can get your REST services to use a Cassandra database.

include::./platform-include.adoc[]
include::_includes/platform-include.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include::_includes/platform-include.adoc[]
include::{includes}/platform-include.adoc[]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it together with a few other occurrences.

Quarkus Documentation automation moved this from To do to Review pending Oct 17, 2022
- Remove outdated content
- Rename includes/ to _includes/ so that it does not get rendered
- Move all includes to the _includes/ subdirectory
Quarkus Documentation automation moved this from Review pending to Reviewer approved Oct 17, 2022
Copy link
Contributor

@ebullient ebullient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gsmet gsmet merged commit 3f4666c into quarkusio:main Oct 17, 2022
Quarkus Documentation automation moved this from Reviewer approved to Done Oct 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 17, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants