Allow overriding query parameters from a ContainerRequestFilter #28595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
approved these changes
Oct 14, 2022
| // invalidate those | ||
| this.uriInfo = null; | ||
| this.absoluteUri = null; | ||
| return this; | ||
| } | ||
|
|
||
| protected void setQueryParamsFrom(String uri) { | ||
| throw new NotImplementedYet(); |
There was a problem hiding this comment.
I think this is very dangerous (new implementations of this class won't realize that this method needs to be implemented until they create a new instance of it). I would make this method abstract.
There was a problem hiding this comment.
Ideally yes, but I don't want to change this important class at this point
This comment has been minimized.
This comment has been minimized.
geoand
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #28555