Validate media types for sub resources in Resteasy Reactive #28565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Oct 13, 2022
geoand
added
triage/backport-2.13
triage/waiting-for-ci
At the moment, there are two places where resteasy reactive is verifying the media types: (1) at the handler `ClassRoutingHandler` only for the main resources (it's not invoked for sub-resources; and (2) at the handler `RequestDeserializeHandler` for the rest. The issue is that the verification at `RequestDeserializeHandler` takes the one from the user which might not be compatible with the one set by the user using the annotation `@Consumes`. Note that I tried to make this handler to be invoked also for sub resources but it caused more troubles and it would not fix the root cause of the issue that is the logic in the handler `RequestDeserializeHandler` is wrong. Fix quarkusio#28460
Failing Jobs - Building bfbfea6
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/flyway/deployment
! Skipped: integration-tests/flyway integration-tests/hibernate-orm-tenancy/datasource integration-tests/hibernate-orm-tenancy/schema and 1 more📦 extensions/flyway/deployment✖ ⚙️ JVM Tests - JDK 18 #- Failing: extensions/flyway/deployment
! Skipped: integration-tests/flyway integration-tests/hibernate-orm-tenancy/datasource integration-tests/hibernate-orm-tenancy/schema and 1 more📦 extensions/flyway/deployment✖ |
|
@gastaldi ^ seems like the Flyway issues I was seeing locally... |
|
@geoand Ah-ha! Now I see these errors too: it's weird that I get a |
|
We'll need to get to the bottom of it - at the very least we need to disable those tests |
|
@geoand that error you are seeing locally is intended, it appears when |
|
Then something fishy is going on 🙂 |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there are two places where resteasy reactive is verifying the media types: (1) at the handler
ClassRoutingHandleronly for the main resources (it's not invoked for sub-resources, and (2) at the handlerRequestDeserializeHandlerfor the rest.The issue is that the verification at
RequestDeserializeHandlertakes the one from the user which might not be compatible with the one set by the user using the annotation@Consumes.Note that I tried to make this handler be invoked also for sub-resources but it caused more troubles and it would not fix the root cause of the issue that is the logic in the handler
RequestDeserializeHandleris wrong.Fix #28460